-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support 3rd party dashboard plugins (DHIS2-17283) #3051
Open
edoardo
wants to merge
95
commits into
master
Choose a base branch
from
feat/support-custom-plugin-DHIS2-17283
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This silences warnings in the console.
Link is rendering an a tag, and MenuItem does the same. Use a redirect on click instead (already done in the print submenu)
This hopefully has a better solution.
It should be enough to just use isParentCached for knowing when to start recording and removing the cache in the plugins.
This should fix some issues with plugin content not being visible.
This is to avoid the error boundary to show up for uncaught errors (failed to fetch a visualization) which interferes with Cypress testing.
🚀 Deployed on https://pr-3051.dashboard.netlify.dhis2.org |
* chore(deps): bump the security group with 3 updates Updates `ejs` from 3.1.8 to 3.1.10 - [Release notes](https://github.com/mde/ejs/releases) - [Commits](mde/ejs@v3.1.8...v3.1.10) Updates `tmpl` from 1.0.4 to 1.0.5 - [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5) Updates `word-wrap` from 1.2.3 to 1.2.5 - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.5) --- updated-dependencies: - dependency-name: ejs dependency-type: indirect dependency-group: security - dependency-name: tmpl dependency-type: indirect dependency-group: security - dependency-name: word-wrap dependency-type: indirect dependency-group: security ... Signed-off-by: dependabot[bot] <[email protected]> * chore: break up command chain --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jen Jones Arnesen <[email protected]>
Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 3.0.0 to 3.0.1. - [Release notes](https://github.com/chalk/ansi-regex/releases) - [Commits](chalk/ansi-regex@v3.0.0...v3.0.1) --- updated-dependencies: - dependency-name: ansi-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jen Jones Arnesen <[email protected]>
This is a promise that the plugin passes to dashboard app. Regardless of the promise outcome, the dashboard item is always deleted, but only after calling the promise. This gives plugins a chance to do some cleanup before the iframe is removed from the DOM.
This is related to the previous fix of the default initialisation of appDetails.
Remove the Cover component as it does not cover anything...
edoardo
removed
the
e2e record
Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud
label
Dec 12, 2024
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-17283
Key features
Description
Dashboard app should have support for custom plugins built with the DHIS2 tooling.
This assumes the plugin uses the platform's components that provide the postRobot communication compatible with this version of dashboard app.
TODO
Known issues
Screenshots
Example with the Climate data app: